Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Tf-eager policy bug fix: Duplicate model call in compute_gradients. #12682

Merged
merged 1 commit into from
Dec 9, 2020
Merged

[RLlib] Tf-eager policy bug fix: Duplicate model call in compute_gradients. #12682

merged 1 commit into from
Dec 9, 2020

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 8, 2020 •
edited
Loading

This PR removes a bug in the EagerTFPolicy:

  • In self._compute_gradients we perform an unnecessary model call before calling the loss function. The model call has simply been removed.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 requested a review from ericl December 8, 2020 21:17
@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 8, 2020
@sven1977 sven1977 merged commit 28108c9 into ray-project:master Dec 9, 2020
@sven1977 sven1977 deleted the tf_eager_bug_fix_duplicate_model_call branch June 2, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

Assignees

@ericl ericl

Labels
@author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sven1977 @ericl