Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Issue 12516: Trainer.compute_action() throws error w/ Dict observation space and num_workers > 0. #12706

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 9, 2020

This PR fixes issue 12516:

  • Trainer.compute_action() throws error w/ Dict observation space and num_workers > 0.

The problem was that the local-worker (driver) was using the already preprocessed space (got it from the remote-worker) to build its own policy/preprocessot stack. That's why the necessary DictFlatteningPreprocessor was never built and your Trainer did not do any preprocessing (on your input dict's observation) prior to sending the data to the Policy.

Closes issue #12516

Closes issue #12516

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ericl ericl merged commit ea25482 into ray-project:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants