Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serve] Migrate from Flask.Request to Starlette Request #12852

Merged
merged 17 commits into from
Dec 21, 2020
Merged

[Serve] Migrate from Flask.Request to Starlette Request #12852

merged 17 commits into from
Dec 21, 2020

Conversation

architkulkarni
Copy link
Contributor

@architkulkarni architkulkarni commented Dec 14, 2020 •
edited
Loading

This PR makes backends take in a Starlette request instead of a Flask request. For the ServeHandle API, ServeRequest has been modified to match Starlette Request instead of Flask Request. All docs and code samples have been updated.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

simon-mo
simon-mo approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's make sure all the doc is updated and finish the TODOs!

@simon-mo simon-mo added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 14, 2020
@architkulkarni architkulkarni added tests-ok The tagger certifies test failures are unrelated and assumes personal liability. and removed @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. labels Dec 15, 2020
@architkulkarni architkulkarni changed the title [Serve] [WIP] Migrate from Flask.Request to Starlette Request [Serve] Migrate from Flask.Request to Starlette Request Dec 15, 2020
@edoakes edoakes merged commit 8b4b4bf into ray-project:master Dec 21, 2020
@architkulkarni architkulkarni linked an issue Dec 22, 2020 that may be closed by this pull request
[serve] Support Starlette Request type #12300
Closed
cathrinS pushed a commit to cathrinS/ray that referenced this pull request Dec 29, 2020
@architkulkarni @cathrinS
[Serve] Migrate from Flask.Request to Starlette Request (ray-project#…
46430e7 
…12852)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

Assignees

@edoakes edoakes

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[serve] Support Starlette Request type
3 participants
@architkulkarni @simon-mo @edoakes