[serve] Support for imported backends #12923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
changed the title
architkulkarni
approved these changes
Dec 16, 2020
| @@ -342,3 +342,37 @@ def get_node_id_for_actor(actor_handle): | |||
| """Given an actor handle, return the node id it's placed on.""" | |||
|
|
|||
| return ray.actors()[actor_handle._actor_id.hex()]["Address"]["NodeID"] | |||
|
|
|||
|
|
|||
| def import_class(full_path: str): | |||
There was a problem hiding this comment.
This is neat! Maybe it could be useful elsewhere in Ray. I almost feel like this should be a built-in function in Python, but maybe there are good reasons for it not to be.
There was a problem hiding this comment.
This is basically recreating:
from module.submodule import Class just using the lower-level API, so it sort of is a built-in function :)
simon-mo
reviewed
Dec 16, 2020
edoakes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In some cases users may not want to pass the backend class directly, but instead import it on the remote machine. For example, the backend may have different dependencies than the local machine/driver.
This provides an application-level wrapper where the user can just pass an import path and the class will be imported in the replica:
Related issue number
Checks
scripts/format.shto lint the changes in this PR.