Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Change pickle to ray.cloudpickle -- support large models #12958

Merged
merged 2 commits into from
Dec 18, 2020
Merged

[tune] Change pickle to ray.cloudpickle -- support large models #12958

merged 2 commits into from
Dec 18, 2020

Conversation

FarzanT
Copy link
Contributor

@FarzanT FarzanT commented Dec 17, 2020 •
edited
Loading

Why are these changes needed?

To be able to pickle models larger than 4 GB.

Related issue number

Closes #12650

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

richardliaw
richardliaw reviewed Dec 17, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you make the same change in ray/python/ray/tune/utils/trainable.py? The pickle serialization step is done there.

@richardliaw richardliaw changed the title Change pickle to ray.cloudpickle [tune] Change pickle to ray.cloudpickle Dec 17, 2020
@richardliaw richardliaw self-assigned this Dec 17, 2020
@FarzanT
Copy link
Contributor Author

FarzanT commented Dec 18, 2020

I think I just did that!

richardliaw
richardliaw approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! thanks a bunch for this fix -- i'll make sure tests pass and merge it in.

@richardliaw richardliaw changed the title [tune] Change pickle to ray.cloudpickle [tune] Change pickle to ray.cloudpickle -- support large models Dec 18, 2020
@richardliaw richardliaw merged commit 5337817 into ray-project:master Dec 18, 2020
@richardliaw
Copy link
Contributor

merged -- thanks a bunch @FarzanT !

@FarzanT
Copy link
Contributor Author

FarzanT commented Dec 18, 2020

@richardliaw Thank you for letting me learn how to contribute (although you already gave me the answer haha)

@FarzanT FarzanT deleted the PickleFix branch December 18, 2020 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

Assignees

@richardliaw richardliaw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tune] OverflowError: cannot serialize a bytes object larger than 4 GiB in pickle_checkpoint
2 participants
@FarzanT @richardliaw