Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ray_client] Fix and extend get_actor test to detached actors #13016

Merged
merged 2 commits into from
Jan 26, 2021
Merged

[ray_client] Fix and extend get_actor test to detached actors #13016

merged 2 commits into from
Jan 26, 2021

Conversation

barakmich
Copy link
Contributor

Why are these changes needed?

Fixes the flake noticed at https://travis-ci.com/github/ray-project/ray/jobs/463426793

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes edoakes added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Dec 22, 2020
@edoakes
Copy link
Contributor

edoakes commented Dec 22, 2020

@barakmich tests failing

@edoakes
Copy link
Contributor

edoakes commented Jan 14, 2021

@barakmich ping on this

@barakmich
Fix and extend get_actor test to detached actors
fcc0600 
Change-Id: I58b61bfa25b52046e73bd7576d2454bc7d1f95fd
@barakmich
formatting
da66c95 
Change-Id: Ia94af0d60c39b8805f20a23e171d616ffade385f
@barakmich
Copy link
Contributor Author

rebased -- let's see how the test runs

@barakmich barakmich removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 22, 2021
@edoakes edoakes merged commit f490e2b into ray-project:master Jan 26, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@barakmich @fishbone
[ray_client] Fix and extend get_actor test to detached actors (ray-pr…
b656a2f 
…oject#13016)
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "[ray_client] Fix and extend get_actor test to detached actors (…
e1d1018 
…ray-project#13016)"

This reverts commit b656a2f.
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "[ray_client] Fix and extend get_actor test to detached actors (…
84ddbfe 
…ray-project#13016)"

This reverts commit b656a2f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@edoakes edoakes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@barakmich @edoakes