Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Placement Group]Add detached support for placement group. #13582

Merged
merged 18 commits into from
Jan 27, 2021
Merged

[Placement Group]Add detached support for placement group. #13582

merged 18 commits into from
Jan 27, 2021

Conversation

clay4444
Copy link
Contributor

Why are these changes needed?

support detached properties for placement group.

Related issue number

#13541

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@clay4444 clay4444 changed the title Add detached support for pg [Placement Group]Add detached support for placement group. Jan 20, 2021
@rkooo567 rkooo567 self-assigned this Jan 20, 2021
@rkooo567
Copy link
Contributor

Also, can you update the documentation?

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 22, 2021
@clay4444 clay4444 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 24, 2021
rkooo567
rkooo567 reviewed Jan 26, 2021
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor few comments!

python/ray/tests/test_placement_group.py Show resolved Hide resolved
doc/source/placement-group.rst Outdated Show resolved Hide resolved
doc/source/placement-group.rst Show resolved Hide resolved
doc/source/placement-group.rst Show resolved Hide resolved
@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 26, 2021
@clay4444 clay4444 removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 26, 2021
rkooo567
rkooo567 approved these changes Jan 27, 2021
View reviewed changes
doc/source/placement-group.rst Outdated Show resolved Hide resolved
doc/source/placement-group.rst Outdated Show resolved Hide resolved
doc/source/placement-group.rst Outdated Show resolved Hide resolved
doc/source/placement-group.rst Outdated Show resolved Hide resolved
doc/source/placement-group.rst Outdated Show resolved Hide resolved
doc/source/placement-group.rst Outdated Show resolved Hide resolved
doc/source/placement-group.rst Outdated Show resolved Hide resolved
@rkooo567
Copy link
Contributor

Please address the last comment!

@ffbin ffbin merged commit 7f6d326 into ray-project:master Jan 27, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@clay4444 @fishbone
[Placement Group]Add detached support for placement group. (ray-proje…
fbe9a68 
…ct#13582)
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "[Placement Group]Add detached support for placement group. (r…
b1c5af6 
…ay-project#13582)"

This reverts commit fbe9a68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 approved these changes

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@ffbin ffbin Awaiting requested review from ffbin

Assignees

@ffbin ffbin

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clay4444 @rkooo567 @ffbin