Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kubernetes][operator][minutiae] Backwards compatibility of operator #13623

Conversation

DmitriGekhtman
Copy link
Contributor

Why are these changes needed?

#13588 deleted a field from the CRD.

This PR makes a tiny change so that the deletion doesn't create a version compatibility issue
when deploying the operator using the CRD in a version of Ray slightly older than current master.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Ran the operator unit test.

@DmitriGekhtman DmitriGekhtman changed the title [kubernetes][operator][minutiae] [kubernetes][operator][minutiae] Backwards compatibility of operator Jan 22, 2021
@edoakes edoakes merged commit 7fec19d into ray-project:master Jan 22, 2021
@DmitriGekhtman DmitriGekhtman deleted the k8s-operator-backwards-compatibility branch January 25, 2021 22:03
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants