[ray_client] convert things registered for ray into ray_client #13639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barakmich
changed the title
Change-Id: I3c77f5438d6842f2b3d6d61f0e80674b1803f130
Change-Id: I358c0ed1385a7dd5b47d118419c95323dc288c53
Change-Id: I3b45d1db8412f17e0b014c61a62a4cf58d00554a
barakmich
force-pushed
the
client_convert_registered_things
branch
from
faf0f57
to
820d705
Compare
Change-Id: I3b6d7835cf90580e72e0ccac057848975132fb7a
|
One question I have is actor classes now are different depending on whether they were created before |
ericl
requested changes
Jan 30, 2021
ericl
added
the
@author-action-required
|
Let's see if we can remove the other hooks for remote instantiation. We can't get rid of it from |
Change-Id: Ieedc57f3c86a2db3f715736b529514946fcf01c3
barakmich
removed
the
@author-action-required
ericl
approved these changes
Feb 1, 2021
|
Good comment :) |
|
python/ray/_private/client_mode_hook.py:5:80: E501 line too long (84 > 79 characters) |
ericl
added
the
@author-action-required
|
Fixed lint and merged; please note you can check your pending PRs at github.com/pulls to see which ones are blocked on issues in the future. |
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
ray-project#13639)" This reverts commit f523284.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
ray-project#13639)" This reverts commit f523284.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Write tests
Related issue number
Closes #13272
Checks
scripts/format.shto lint the changes in this PR.