Rename the ray.operator module to ray.ray_operator #13705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanthratna
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
tested locally; can confirm that the setup-dev.py issue has been resolved. Thanks!
BTW @DmitriGekhtman, do you know if this will be cherry-picked into the 1.2.0 cut? the issue is marked as P2, not P0, so I'm guessing the answer is no, but I don't see any reason in not picking this over now...
AmeerHajAli
approved these changes
Jan 26, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
* Rename ray.operator module * mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
operatoris a standard Python moduleThe name of this module currently causes issues running
setup-dev.py.See
https://github.com/ray-project/ray/issues/13635It could cause more issues down the line. Better to fix this sooner rather than later.
Related issue number
Closes #13635
Checks
scripts/format.shto lint the changes in this PR.Tested with sufficient paranoia: built linux wheels based on this PR from source, built an image with ray pip-installed from those wheels, ran operator unit test locally with the image.