[tune] fix non-deterministic category sampling by switching back to np.random.choice
#13710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 4, 2021 14:32
sumanthratna
approved these changes
Jan 27, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…np.random.choice` (ray-project#13710) * Enable zoopt tests again, but wait for next release * Add test and preserve state in trial executor * Add baseline check with integers * [tune] fix non-deterministic category sampling, re-enable zoopt tests * Remove random import * Disable zoopt tests
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ack to `np.random.choice` (ray-project#13710)" This reverts commit d8cb6b1.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ack to `np.random.choice` (ray-project#13710)" This reverts commit d8cb6b1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Sampling categories in Ray Tune was non-deterministic even when setting a seed. It is unclear where this comes from exactly, but it might be some external library using python's
randommodule. Switching backtune.choicesampling tonp.random.choicefixes this issue.Note that we introduced the switch to
random.choicein #9451 because of typing incompatibilities. However, transforming the sampled choices to a list should fix these issues. An alternative would be to sample indices and return a list of these indices, but we'll try this regular route as it should be more efficient.Related issue number
Closes #13295
Original issue for switching from
np.random.choicetorandom.choice: #8976Related PR: #9451
Checks
scripts/format.shto lint the changes in this PR.