Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ray_client]: Add python version check and test (and some minor fixes along the way) #13722

Merged
merged 4 commits into from
Feb 1, 2021
Merged

[ray_client]: Add python version check and test (and some minor fixes along the way) #13722

merged 4 commits into from
Feb 1, 2021

Conversation

barakmich
Copy link
Contributor

Related issue number

Closes #13610

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@barakmich
add python version check and test (and some minor fixes along the way)
6b00bc8 
Change-Id: Ib3567fea483e56d99add22538a1ab916d6701cf2
@barakmich
lint
a1a0135 
Change-Id: I6a7ec63e4c71b0aa0c9786eb3da031c37273922d
@barakmich barakmich added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Jan 27, 2021
edoakes
edoakes approved these changes Jan 27, 2021
View reviewed changes
python/ray/util/client/__init__.py Outdated Show resolved Hide resolved
python/ray/util/client/server/dataservicer.py Outdated Show resolved Hide resolved
@barakmich
fix circular reference and add helpful container type
596dc02 
Change-Id: I03fcae9078b6d0e6863818c8ad0491dcdc7f3f61
@barakmich
Copy link
Contributor Author

@edoakes PTAL

@edoakes
Copy link
Contributor

edoakes commented Jan 28, 2021

@barakmich nice! Looks like test_client_reference is failing:
https://travis-ci.com/github/ray-project/ray/jobs/477475202

Just wanted to make sure before merging -- is this unrelated?

@barakmich
fix removal of private function
48a2497 
Change-Id: I62da31e31e87c5331a7152e43b490d0eb3421f23
@barakmich
Copy link
Contributor Author

@edoakes Yep, that was on me. Fixed.

@ericl ericl merged commit 55566bc into ray-project:master Feb 1, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@barakmich @fishbone
[ray_client]: Add python version check and test (and some minor fixes…
b4c187d 
… along the way) (ray-project#13722)
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
@fishbone
Revert "[ray_client]: Add python version check and test (and some min…
3d04638 
…or fixes along the way) (ray-project#13722)"

This reverts commit b4c187d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edoakes edoakes edoakes approved these changes

Assignees

@edoakes edoakes

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise error on Python version mismatch (3.6 vs 3.7)
3 participants
@barakmich @edoakes @ericl