Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray_client]: hook runtime context #13750

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Conversation

barakmich
Copy link
Contributor

Calling ray.util.connect separately caused the issue. The intention at the start was from ray.util.connect import ray instead of just import ray -- and then we've been finding ways to hook "real" ray.

So we just gotta add the hook. One liner!

Related issue number

Closes #13748

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Change-Id: I701d21e53900b5f3fb0e23e09f59e8316c7ba623
@ericl ericl merged commit 9441f85 into ray-project:master Jan 29, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Change-Id: I701d21e53900b5f3fb0e23e09f59e8316c7ba623
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ray_client] ray.get_runtime_context().node_id not working
3 participants