[autoscaler][kubernetes][operator] Rudimentary error handling, make "MODIFIED" -> update event work. #13756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmeerHajAli
added
the
@author-action-required
DmitriGekhtman
force-pushed
the
operator-error-handling
branch
from
904a362
to
f5a368b
Compare
DmitriGekhtman
changed the title
DmitriGekhtman
removed
the
@author-action-required
|
@yiranwang52 @edoakes |
edoakes
approved these changes
Feb 3, 2021
|
@edoakes Could you merge this? |
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…MODIFIED" -> update event work. (ray-project#13756)
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…, make "MODIFIED" -> update event work. (ray-project#13756)" This reverts commit 3749d2d.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…, make "MODIFIED" -> update event work. (ray-project#13756)" This reverts commit 3749d2d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
(A)
This PR adds to the CRD a
statussubresource with aphasefield.The phase field is either
Runningwhen things are as normal orErrorwhen there's an Python exception thrown processing one of the ADDED/MODIFIED/DELETED events for a RayCluster CR.(Previously an error would completely stop the operator.)
The status is printed with
kubectl get raycluster. For example:(B)
This PR also fixes the operator's update logic -- previously, upon receiving a "MODIFIED" event for a CR, it would relaunch the cluster without updating the cluster config . The config is now modified.
If this PR is merged, there would be an incompatibility between versions of operator.yaml slightly older than latest master and the operator code in
rayproject/ray:nightlywhich is the image used in operator.yaml.(The new operator code acts on
rayclusters/statusbut the oldoperator.yamldoesn't grant that permission.)Partly motivated by that, I've added a note to operator documentation saying that the operator is experimental and the config files from latest master should be used.
Related issue number
Closes #13669
Checks
scripts/format.shto lint the changes in this PR.Added logic testing that cluster update works to operator unit test. Unit test passes locally.
Manually tested the
Errorstatus logic by inserting nonsense into theMODIFIEDelif branch. Figuring out how to unit test this is too much effort for now.