Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix get action shape #13764

Merged

Conversation

stanislav-chekmenev
Copy link
Contributor

Why are these changes needed?

Fixes the error in 13761. Added an argument specifying the framework in get_action_space() when called from rllib/policy/policy.py

Related issue number

To close issue 13761

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@stanislav-chekmenev stanislav-chekmenev changed the title Fix get action shape [RLlib] Fix get action shape Jan 28, 2021
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Feb 2, 2021
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @stanislav-chekmenev !

@sven1977 sven1977 merged commit b9c15a2 into ray-project:master Feb 2, 2021
@stanislav-chekmenev stanislav-chekmenev deleted the fix_get_action_shape branch February 2, 2021 12:53
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants