Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] catch SIGINT signal and trigger experiment checkpoint #13767

Merged
merged 4 commits into from
Feb 2, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

With this PR, users can gracefully exit a tuning run anytime.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections for now but would consider

  • a way to disable this
  • some more documentation about this behavior change

do feel free to merge at will

@krfricke
Copy link
Contributor Author

Great, thanks for the feedback. I added both, and a new paragraph in the user guide for resuming experiments.

@krfricke krfricke merged commit d29fcfb into ray-project:master Feb 2, 2021
@krfricke krfricke deleted the tune-sigint branch February 2, 2021 13:52
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
…ject#13767)

* [tune] catch SIGINT signal and trigger experiment checkpoint

* Apply suggestions from code review

* Fix user guide docs

* Update doc/source/tune/user-guide.rst
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants