-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the tune driver into a remote task #13778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good. Some tests are failing for initialization reasons, this is probably a one line fix
if _remote is None: | ||
_remote = ray.util.client.ray.is_connected() | ||
if _remote and not trial_executor: | ||
_ray_auto_init() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be moved to the else block?
python/ray/tune/tune.py
Outdated
get_fn = ray.get | ||
exec_impl = ray.remote(num_cpus=0)(_tune_run_impl).remote | ||
else: | ||
get_fn = lambda x: x # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe throw a warning/exception if remote=True
and a trial executor have been passed explicitly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(feel free to ignore though since this is a private parameter for now)
Actually, instead of using the
This way we keep the functionality in the |
Great suggestion; updated. |
This reverts commit 3282485.
This reverts commit 3282485.
Why are these changes needed?
This allows Tune to work efficiently (and work correct log dirs) when running in Ray client against a remote cluster.
TBD: whether this is on by default