[core][object spillin] Fix bugs in admission control #13781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkooo567
approved these changes
Jan 29, 2021
| RAY_LOG(DEBUG) << "Updated size of object " << object_id << " to " << object_size | ||
| << ", num bytes being pulled is now " << num_bytes_being_pulled_; | ||
| if (it->second.object_size == 0) { | ||
| RAY_LOG(WARNING) << "Size of object " << object_id |
There was a problem hiding this comment.
Why don't we just RAY_CHECK here? Can you write a comment when's the case the size is 0 in normal condition?
ericl
added
the
@author-action-required
wuisawesome
pushed a commit
that referenced
this pull request
Feb 11, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ject#13781)" This reverts commit f3ce811.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…ject#13781)" This reverts commit f3ce811.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This fixes two bugs in admission control:
Checks
scripts/format.shto lint the changes in this PR.These bugs are hard to test for because they require integration testing and the corner cases are subtle.