Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Placement Group] Support named placement group java api & Refactor construct method #13821

Merged

Conversation

clay4444
Copy link
Contributor

Why are these changes needed?

This pr contains the following changes:

  1. Refactor creation construct method of placement group and make it creation from a Option, the advantage of this is that if we want to add new features in the future, we no longer need to modify the constructor and jni interface, only need to modify the Option.
  2. Implement the named placement group for java api

Related issue number

#13625

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kfstorm
Copy link
Member

kfstorm commented Feb 19, 2021

@ffbin @chaokunyang Any more comments?

java/BUILD.bazel Outdated Show resolved Hide resolved
@kfstorm kfstorm merged commit 7647d60 into ray-project:master Feb 22, 2021
@kfstorm kfstorm deleted the support_named_placement_group_java_api branch February 22, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants