[tune] enable placement groups per default #13906

krfricke · 2021-02-04T11:03:08Z

Why are these changes needed?

Related issue number

Checks

I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

…uments instead of callables

# Conflicts: # python/ray/tune/ray_trial_executor.py # python/ray/tune/tests/test_trial_runner_callbacks.py

python/ray/tune/utils/placement_groups.py

src/ray/object_manager/plasma/store.cc

python/ray/tune/schedulers/pbt.py

python/ray/tune/tests/test_progress_reporter.py

This reverts commit 933d9c4

…g-rollout

…llout

Signed-off-by: Richard Liaw <rliaw@berkeley.edu>

…g-rollout

richardliaw · 2021-02-23T16:30:26Z

tests are good!

richardliaw

nice work!

Kai Fricke added 8 commits February 2, 2021 15:56

Refactor placement group factory object to accept placement_group arg…

613b548

…uments instead of callables

Convert resources to pgf

d53e03e

Enable placement groups per default

941ae4d

Fix tests WIP

ad4233b

Fix stop/resume with placement groups

ca60ae9

Merge branch 'master' into tune-pg-rollout

e6df003

# Conflicts: # python/ray/tune/ray_trial_executor.py # python/ray/tune/tests/test_trial_runner_callbacks.py

Fix progress reporter test

9c42f7c

Fix trial executor tests

47b7760

richardliaw reviewed Feb 5, 2021

View reviewed changes

python/ray/tune/utils/placement_groups.py Show resolved Hide resolved

richardliaw reviewed Feb 5, 2021

View reviewed changes

src/ray/object_manager/plasma/store.cc Outdated Show resolved Hide resolved

Kai Fricke added 7 commits February 5, 2021 11:30

Check resource for trial, not resource object

5a6ed96

Move ENV vars into class

8cf789a

Fix tests

d92114f

Sphinx

9013d38

Wait for trial start in PBT

fc234a2

Merge branch 'master' into tune-pg-rollout

0692443

Revert merge errors

e9f829c

krfricke commented Feb 5, 2021

View reviewed changes

python/ray/tune/schedulers/pbt.py Outdated Show resolved Hide resolved

krfricke commented Feb 5, 2021

View reviewed changes

python/ray/tune/tests/test_progress_reporter.py Show resolved Hide resolved

Kai Fricke added 11 commits February 5, 2021 19:46

Support trial reuse with placement groups

8fdfd7f

Better check for just staged trials

08b13d8

Fix trial queuing

51a836b

Wait for pg after trial termination

d92085d

Merge branch 'master' into tune-pg-rollout

96a04ff

Clean up PGs before tune run

c4ab966

No PG settings in pbt scheduler

3d87bde

Fix buffering tests

e60540d

Skip test if ray reports erroneous available resources

a03c623

Disable PG for cluster resource counting test

a45a589

Merge remote-tracking branch 'upstream/master' into tune-pg-rollout

95df940

Kai Fricke added 5 commits February 12, 2021 12:18

Update FAQ example

019a48a

Requeue trial if start was unsuccessful

95d09b6

Merge branch 'master' into tune-pg-rollout

0dad02b

Do not cleanup pgs at start of run

933d9c4

Revert "Do not cleanup pgs at start of run"

7287639

This reverts commit 933d9c4

krfricke mentioned this pull request Feb 13, 2021

[core] removing placement group with a scheduled actor raises "!is_infeasible" and crashes Ray Tune #14092

Closed

2 tasks

Kai Fricke and others added 5 commits February 15, 2021 10:10

Merge branch 'master' into tune-pg-rollout

cc11947

Delayed PG removal

8f6dee2

Fix trial requeue test

667ca34

Trigger pg cleanup on status update

66a3d04

Merge branch 'tune-pg-rollout' of github.com:krfricke/ray into tune-p…

8e537c8

…g-rollout

richardliaw mentioned this pull request Feb 16, 2021

[tune/core] Ray core worker seems to hang with placement groups? #14124

Closed

Kai Fricke and others added 10 commits February 16, 2021 15:41

Fix tests

fdd6be9

Merge remote-tracking branch 'upstream/master' into tune-pg-rollout

0a92b6b

Fix docs

ec7c531

Merge branch 'tune-pg-rollout' of github.com:krfricke/ray into tune-p…

27f1202

…g-rollout

Merge branch 'master' into tune-pg-rollout

53763e9

Merge branch 'master' into tune-pg-rollout

7a8c2ee

Merge branch 'master' into tune-pg-rollout

9392d91

Merge branch 'master' into tune-pg-rollout

75d1601

Merge remote-tracking branch 'origin/tune-pg-rollout' into tune-pg-ro…

41bc732

…llout

Merge branch 'master' into tune-pg-rollout

46e9875

richardliaw mentioned this pull request Feb 23, 2021

[placement groups] SIGABORT when using placement groups #14269

Closed

richardliaw added 2 commits February 22, 2021 20:56

fix-test

4dde742

Signed-off-by: Richard Liaw <rliaw@berkeley.edu>

Merge branch 'tune-pg-rollout' of github.com:krfricke/ray into tune-p…

51ae110

…g-rollout

krfricke marked this pull request as ready for review February 23, 2021 17:11

richardliaw approved these changes Feb 23, 2021

View reviewed changes

krfricke merged commit 757866e into ray-project:master Feb 23, 2021

krfricke deleted the tune-pg-rollout branch February 23, 2021 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tune] enable placement groups per default #13906

[tune] enable placement groups per default #13906

krfricke commented Feb 4, 2021

richardliaw commented Feb 23, 2021

richardliaw left a comment

[tune] enable placement groups per default #13906

[tune] enable placement groups per default #13906

Conversation

krfricke commented Feb 4, 2021

Why are these changes needed?

Related issue number

Checks

richardliaw commented Feb 23, 2021

richardliaw left a comment

Choose a reason for hiding this comment