Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] R2D2 Implementation. #13933

Merged
merged 34 commits into from
Feb 25, 2021
Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Feb 5, 2021

An R2D2 implementation, based on DQN (paper: https://openreview.net/pdf?id=r1lyTjAqYX).

  • Tf and Torch policies.

  • Runs and passes the "compilation" tests in all frameworks.

  • Learns CartPole in both tf and torch.

  • Rudimentary documentation.

  • Supports: Burn-in.

  • TODO (follow up PRs):

    • Support for non-zero init states (init states will be updated after each loss call inside the buffer).
    • Run as APEX (as described in the paper).
    • More benchmarking.
    • Test R2D2 with prio. replay buffer (expected to work, but not tested properly yet).

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 marked this pull request as ready for review February 9, 2021 16:06
doc/source/rllib-algorithms.rst Show resolved Hide resolved
rllib/agents/dqn/dqn_torch_policy.py Outdated Show resolved Hide resolved
rllib/agents/dqn/r2d2.py Outdated Show resolved Hide resolved
rllib/agents/dqn/r2d2.py Show resolved Hide resolved
rllib/agents/dqn/r2d2.py Outdated Show resolved Hide resolved
rllib/agents/dqn/r2d2_tf_policy.py Show resolved Hide resolved
rllib/agents/dqn/r2d2_tf_policy.py Show resolved Hide resolved
rllib/agents/dqn/r2d2_tf_policy.py Show resolved Hide resolved
rllib/agents/dqn/r2d2_torch_policy.py Show resolved Hide resolved
rllib/policy/eager_tf_policy.py Show resolved Hide resolved
@sven1977
Copy link
Contributor Author

@michaelzhiluo this is ready for review again ^^

@sven1977 sven1977 merged commit 8000258 into ray-project:master Feb 25, 2021
@sven1977 sven1977 deleted the r2d2_implementation branch March 27, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants