Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Add try-except to FailureInjectorCallback #13939

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Feb 5, 2021

Adds a try-except statement to handle any failures when killing random nodes in the long running distributed test.

Why are these changes needed?

Related issue number

Closes #13923

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@amogkam amogkam changed the title [Tune/SGD] Add try-except for long running distributed test [Tune] Add try-except to FailureInjectorCallback Feb 5, 2021
@richardliaw richardliaw merged commit f44f368 into ray-project:master Feb 5, 2021
wuisawesome pushed a commit to wuisawesome/ray that referenced this pull request Feb 5, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long running distributed test fails
3 participants