[Core]Pull off timers out of heartbeat in raylet #13963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangTaoTheTonic
changed the title
|
Tests all failing... |
rkooo567
added
the
@author-action-required
|
Looks like something wrong with pull manager, revert that part first and test are passed. |
WangTaoTheTonic
added
tests-ok
|
ping @rkooo567 |
raulchen
reviewed
Feb 22, 2021
src/ray/util/util.cc
Outdated
| @@ -362,3 +362,18 @@ std::shared_ptr<std::unordered_map<std::string, std::string>> ParseURL(std::stri | |||
| result->emplace(key_value_pair.first, key_value_pair.second); | |||
| return result; | |||
| } | |||
|
|
|||
| void RunFnPeriodically(std::function<void()> fn, boost::posix_time::milliseconds period, | |||
There was a problem hiding this comment.
Maybe we can change this to a helper class (say PeriodicRunner), so the callers can just pass in a function and a period, without having to be aware of the timers.
There was a problem hiding this comment.
great! I'll change that.
rkooo567
added
@author-action-required
|
Still seems to have many test failures. |
raulchen
approved these changes
Feb 23, 2021
| /// \class PeriodicalRunner | ||
| /// A periodical runner attached with an io_context. | ||
| /// It can run functions with specified period. Each function is triggered by its timer. | ||
| /// To run a function, call `RunFnPeriodically(fn, period_ms)`. |
There was a problem hiding this comment.
Document that when the PeriodicalRunner object is destructed, the registered functions will stop running.
src/ray/util/periodical_runner.h
Outdated
| ~PeriodicalRunner(); | ||
|
|
||
| void RunFnPeriodically(std::function<void()> fn, | ||
| boost::posix_time::milliseconds period); |
There was a problem hiding this comment.
nit: this function can accept a long, so callers don't need to construct a posix_time before calling it.
WangTaoTheTonic
force-pushed
the
raylet_thread
branch
from
e9241bd
to
e893a74
Compare
WangTaoTheTonic
added
tests-ok
richardliaw
added a commit
that referenced
this pull request
Feb 25, 2021
richardliaw
added a commit
to richardliaw/ray
that referenced
this pull request
Feb 25, 2021
…-project#13963)" (ray-project#14319)" This reverts commit 80657e5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I found raylet mixed up many period actions with heartbeat, which is ugly and not easy for us to pick up heartbeat reporting into a separate thread.
This PR do 3 things:
RunFnPeriodically.RunFnPeriodicallyto replace dummy methods that dispatch task in a loop.Related issue number
Checks
scripts/format.shto lint the changes in this PR.