-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[autoscaler/dashboard] Publish resource usage in units of bytes #14002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuisawesome
commented
Feb 9, 2021
@@ -313,12 +313,12 @@ def format_pg(pg): | |||
|
|||
def get_usage_report(lm_summary) -> str: | |||
usage_lines = [] | |||
for resource, (used, total) in lm_summary.usage.items(): | |||
for resource, (used, total) in sorted(lm_summary.usage.items()): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incidental change which is useful in practice for watch ray status
wuisawesome
added
the
tests-ok
The tagger certifies test failures are unrelated and assumes personal liability.
label
Feb 9, 2021
ericl
approved these changes
Feb 9, 2021
fishbone
pushed a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…es (ray-project#14002)" This reverts commit b551231.
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Feb 16, 2021
…es (ray-project#14002)" This reverts commit b551231.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Our 50 MiB internal units are confusing, therefore we should publish our units in bytes which are sane and universal.
Related issue number
Closes #13686
Checks
scripts/format.sh
to lint the changes in this PR.