Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray_client]: Set gRPC max message size to 4GiB #14063

Merged
merged 5 commits into from
Feb 16, 2021

Conversation

barakmich
Copy link
Contributor

Why are these changes needed?

Closes #13912 in a simple manner

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Change-Id: Id4d6887cdd90dd761dd25248f10f104701462667
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass

@ericl
Copy link
Contributor

ericl commented Feb 12, 2021

???
E OverflowError: value too large to convert to int

Heh, maybe 2GB?

@ericl ericl added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 12, 2021
@ericl ericl removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 16, 2021
@ericl ericl merged commit edf2458 into ray-project:master Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ray_client]: Data Stream Chunking
2 participants