Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autoscaler] Fix bad reference when specifying IamInstanceProfile by name #14083

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

pdames
Copy link
Member

@pdames pdames commented Feb 12, 2021

Why are these changes needed?

Fixes a bug that otherwise results in a bad reference error when an IamInstanceProfile is specified by name for head or worker nodes in an AWS Autoscaler Config file, for example:

head_node:
  IamInstanceProfile:
    Name: MyRayClusterIamInstanceProfile

worker_nodes:
  IamInstanceProfile:
    Name: MyRayClusterIamInstanceProfile

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@simon-mo simon-mo merged commit da0c2c9 into ray-project:master Feb 16, 2021
fishbone pushed a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
fishbone added a commit to fishbone/ray that referenced this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants