Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Support extending BOHB/Hyperband runs past max_t #14171

Merged
merged 5 commits into from
Feb 20, 2021

Conversation

richardliaw
Copy link
Contributor

@richardliaw richardliaw commented Feb 18, 2021

Why are these changes needed?

Closes #14169

cc @krfricke @ANarayan

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The hyperband test currently seems to timeout on travis though.

Are the time.sleep(0.1) calls needed to make the examples work?

@richardliaw
Copy link
Contributor Author

richardliaw commented Feb 19, 2021

@krfricke the time sleep is to ensure that some of the bracketing mechanisms work (otherwise, the results get buffered and everything just shoots up to 1000 iterations, instead of going through the standard hyperband halving process)

@ANarayan
Copy link

I tested it out on my end and it seems to work as expected!

Signed-off-by: Richard Liaw <rliaw@berkeley.edu>
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tune] Extending HyperBandForBOHB scheduler to support training the n best trials to completion
3 participants