[Tune] Raise error when PBT is used with search algorithm #14176

amogkam · 2021-02-18T01:35:24Z

We should raise an error when PBT or PB2 are used with a search algorithm to prevent usages like in huggingface/transformers#10247

Why are these changes needed?

I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

python/ray/tune/tune.py

python/ray/tune/schedulers/pbt.py

richardliaw

LGTM! Ping when tests pass

amogkam · 2021-02-19T17:31:28Z

@richardliaw can you merge please, thanks!

raise error

a3f0161

amogkam requested a review from richardliaw February 18, 2021 01:35

amogkam assigned richardliaw Feb 18, 2021

richardliaw reviewed Feb 18, 2021

View reviewed changes

python/ray/tune/tune.py Outdated Show resolved Hide resolved

amogkam added 3 commits February 17, 2021 19:13

update

566cc47

remove import

3774b0e

remove import

0e4616a

richardliaw reviewed Feb 18, 2021

View reviewed changes

python/ray/tune/schedulers/pbt.py Outdated Show resolved Hide resolved

amogkam added 2 commits February 17, 2021 19:34

check type

55ef6ac

fix tests

9ff548c

amogkam requested a review from richardliaw February 19, 2021 01:53

richardliaw approved these changes Feb 19, 2021

View reviewed changes

amogkam added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Feb 19, 2021

richardliaw merged commit 3ffe375 into ray-project:master Feb 19, 2021