Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autoscaler] Limit additional fields in available_node_types::docker #14244

Merged

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Feb 22, 2021

Why are these changes needed?

  • We should not allow arbitrary fields to be set here (the default is additionalProperties = True).

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@AmeerHajAli
Copy link
Contributor

Not sure why TUNE_TESTING is failing. CC @richardliaw

@AmeerHajAli AmeerHajAli merged commit 54ab6d2 into ray-project:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants