Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tune] WandbLoggerCallback compatibility with Ray Client #14280

Merged
merged 3 commits into from
Feb 24, 2021
Merged

[Tune] WandbLoggerCallback compatibility with Ray Client #14280

merged 3 commits into from
Feb 24, 2021

Conversation

amogkam
Copy link
Contributor

@amogkam amogkam commented Feb 23, 2021

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

richardliaw
richardliaw approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is clean!

krfricke
krfricke approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution!

@amogkam amogkam added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Feb 24, 2021
@richardliaw richardliaw merged commit 739f653 into ray-project:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

@krfricke krfricke krfricke approved these changes

Assignees
No one assigned
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amogkam @richardliaw @krfricke