Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCS]Cherry pick heartbeat function into another thread #14301

Merged
merged 5 commits into from
Mar 2, 2021

Conversation

WangTaoTheTonic
Copy link
Contributor

@WangTaoTheTonic WangTaoTheTonic commented Feb 24, 2021

Why are these changes needed?

Related issue number

In normal cases raylet main thread doesn't do too much heavy load, but sometime it could be blocked by some lock operation( we found servral times).
Heartbeat is a light but import action for thread, as it is depended by gcs node failure detecting. To avoid raylet being treated as lost by misunderstand, we'd like it sending heartbeat in a different thread from the main one.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@raulchen raulchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment is that I prefer adding a separate HeartbeatSender class. Because NodeManager is already too huge.

@rkooo567
Copy link
Contributor

rkooo567 commented Mar 1, 2021

Hey do we still need this @wuisawesome with your change? Can you confirm?

@wuisawesome
Copy link
Contributor

I'm in favor of this since it should help prevent issues like #14264

@raulchen raulchen merged commit 2de01ee into ray-project:master Mar 2, 2021
@WangTaoTheTonic WangTaoTheTonic deleted the raylet_thread branch March 2, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants