[rllib] cast fcnet_hiddens to list #14308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ghost
reviewed
Feb 25, 2021
| @@ -24,7 +24,7 @@ def __init__(self, obs_space: gym.spaces.Space, | |||
| model_config, name) | |||
| nn.Module.__init__(self) | |||
|
|
|||
| hiddens = model_config.get("fcnet_hiddens", []) + \ | |||
| hiddens = list(model_config.get("fcnet_hiddens", [])) + \ | |||
| model_config.get("post_fcnet_hiddens", []) | |||
There was a problem hiding this comment.
Suggested change
| model_config.get("post_fcnet_hiddens", []) | |
| list(model_config.get("post_fcnet_hiddens", [])) |
, since post_fcnet_hiddens will be tuple if we use HyperOpt to search its best value (similar to fcnet_hiddens). (detail in #14304)
sven1977
approved these changes
Feb 25, 2021
|
@sven1977 It seems that my suggestion was not added to the code 😢 |
krfricke
pushed a commit
to krfricke/ray
that referenced
this pull request
Feb 25, 2021
|
Probably just an oversight when merging the issue - it's good actually. I created a PR to fix this issue in #14354 - thanks again! |
|
Ah, thanks a lot! |
krfricke
added a commit
that referenced
this pull request
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Cast config parameter to list to make sure that list operations work
Related issue number
Closes #14304
Checks
scripts/format.shto lint the changes in this PR.