Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autoscaler] Fix GCP User Inconsistency #14364

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Feb 26, 2021

Why are these changes needed?

Our previous GCP default OS had the default UID as 1001 (not 1000) and this caused problems with file permissions in our containers. The change here is also logical as we no longer need TF installed on the host OS if we are using containers!

This PR also bumps the CUDA version on the host to match the container version!

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@AmeerHajAli
Copy link
Contributor

@DmitriGekhtman , FYI.

@DmitriGekhtman
Copy link
Contributor

@DmitriGekhtman , FYI.

thanks -- will be mindful of merge issues

@ijrsvt ijrsvt merged commit e1117eb into ray-project:master Feb 26, 2021
@ijrsvt ijrsvt deleted the better-source-image branch February 26, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gcp] Workers do not start on GCP
4 participants