Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Lookup flat key first before trying to split #14388

Merged
merged 1 commit into from
Mar 1, 2021
Merged

[tune] Lookup flat key first before trying to split #14388

merged 1 commit into from
Mar 1, 2021

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

In unflattened_lookup, we should check first if the exact key exists in the result dictionary.

Related issue number

Closes #14237

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke merged commit 8572774 into ray-project:master Mar 1, 2021
@krfricke krfricke deleted the metric-lookup branch March 1, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amogkam amogkam amogkam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tune] JupyterNotebookReporter - Support for "/" in name
2 participants
@krfricke @amogkam