[ray client] Fix ctrl-c for ray.get() by setting a short-server side timeout #14425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmeerHajAli
reviewed
Mar 1, 2021
AmeerHajAli
reviewed
Mar 1, 2021
AmeerHajAli
added
the
@author-action-required
ijrsvt
requested changes
Mar 1, 2021
|
@AmeerHajAli done |
ericl
removed
the
@author-action-required
AmeerHajAli
approved these changes
Mar 2, 2021
|
Seems client tests are timing out |
ericl
added
the
@author-action-required
|
//python/ray/tests:test_actor_client_mode TIMEOUT in 3 out of 3 in 315.0s |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ctrl-C on the client side needs to interrupt the server operation, otherwise future operations block on the original ray.get. However, this is tricky since the server is a single gRPC stream servicer. For now, workaround this with a short server-side timeout. The client breaks down long-running gets into multiple short-running polls for get up to the deadline. If the client cancels, it just needs to wait for the last operation to expire.
Future work: do this for ray.wait(), which is a bit trickier since you have to support num_returns.