Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Fix HEBO evaluated rewards for max mode & save/restore #14427

Merged
merged 3 commits into from
Mar 3, 2021

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Mar 1, 2021

Why are these changes needed?

If HEBO is set to maximize, evaluated rewards need to be multiplied by -1. Apologies, didn't catch that before.

Furthermore, this PR also makes sure that all the necessary attributes are saved and restored.

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Yard1
Copy link
Member Author

Yard1 commented Mar 1, 2021

CC @krfricke

@krfricke
Copy link
Contributor

krfricke commented Mar 2, 2021

Can you run ./scripts/format.sh once to run the linter?

@Yard1 Yard1 changed the title [Tune] Fix HEBO evaluated rewards for max mode [Tune] Fix HEBO evaluated rewards for max mode & save/restore Mar 2, 2021
@Yard1
Copy link
Member Author

Yard1 commented Mar 2, 2021

@krfricke I've also pushed a commit that'll make sure that all the necessary attributes are saved and restored - that should fix that issue on Slack, at least for HEBO.

@krfricke krfricke merged commit 85a092c into ray-project:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants