[Tune] HEBO concurrency fix after discussion with authors #14504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krfricke HEBO authors have been insistent on this change, let me know if you think there's a better way to limit concurrency in a searcher itself. |
richardliaw
reviewed
Mar 5, 2021
Comment on lines
+254
to
257
| n_suggestions=self._max_concurrent) | ||
| self._suggestions_cache = suggestion.to_dict("records") | ||
| params = self._suggestions_cache.pop(0) | ||
| suggestion = pd.DataFrame(params, index=[0]) |
There was a problem hiding this comment.
If you return n_suggestions here, what happens? Does it return a list of dicts instead?
There was a problem hiding this comment.
HEBO outputs and inputs dataframes, so with n_suggestions set to eg. 4 it would output a 4 row dataframe
richardliaw
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR implements a new concurrency limiting system built into the
HEBOSearchsearcher itself (similar to the one inTuneBOHB) in order to ensure the algorithm works as intended. This removes the need for wrappingHEBOSearchin aConcurrencyLimiter.The new behavior is to limit the amount of concurrent trials to the value of
max_concurrentargument and ensure they are done in batches.Hopefully this will be the last PR for this 馃槄
Checks
scripts/format.shto lint the changes in this PR.