Add basic concurrency test for ray client #14630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! let me try this out.
…On Thu, Mar 11, 2021 at 12:18 PM Eric Liang ***@***.***> wrote:
Assigned #14630 <#14630> to
@richardliaw <https://github.com/richardliaw>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#14630 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABCRZZJESH3HNBZ624Q2F7DTDEJOXANCNFSM4ZA6TK3Q>
.
|
|
does it make sense to test this?
…On Thu, Mar 11, 2021 at 1:18 PM Richard Liaw ***@***.***> wrote:
nice! let me try this out.
On Thu, Mar 11, 2021 at 12:18 PM Eric Liang ***@***.***>
wrote:
> Assigned #14630 <#14630> to
> @richardliaw <https://github.com/richardliaw>.
>
> —
> You are receiving this because you were assigned.
> Reply to this email directly, view it on GitHub
> <#14630 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABCRZZJESH3HNBZ624Q2F7DTDEJOXANCNFSM4ZA6TK3Q>
> .
>
|
ericl
changed the title
|
Actually, I realized this is not needed since the client impl is actually thread-safe (added a simple test). I think your original issue is unrelated. |
AmeerHajAli
approved these changes
Mar 12, 2021
|
Sorry, it's actually not fixing the issue (fixed the description). This is just adding another test to avoid regressions on this front. |
AmeerHajAli
added
the
@author-action-required
ijrsvt
reviewed
Mar 12, 2021
| time.sleep(1) | ||
|
|
||
| # Can concurrently execute the get. | ||
| assert ray.get(fast.remote(), timeout=5) == "ok" |
There was a problem hiding this comment.
OOC, will this introduce flakiness in an over-loaded test environment?
|
The timeout is 5 seconds, which should be pretty generous... depends on how
overloaded the servers are. I can increase it to say 15 if there is a
concern?
…On Fri, Mar 12, 2021 at 3:19 PM Ian Rodney ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In python/ray/tests/test_client.py
<#14630 (comment)>:
> + return "ok"
+
+ class Blocker(threading.Thread):
+ def __init__(self):
+ threading.Thread.__init__(self)
+ self.daemon = True
+
+ def run(self):
+ ray.get(block.remote())
+
+ b = Blocker()
+ b.start()
+ time.sleep(1)
+
+ # Can concurrently execute the get.
+ assert ray.get(fast.remote(), timeout=5) == "ok"
OOC, will this introduce flakiness in an over-loaded test environment?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14630 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADUSRHEHCD62VRFJMIMHTTDKHPPANCNFSM4ZA6TK3Q>
.
|
|
@ericl 5 is probably fine, we can always bump in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.