Bump Ray client protocol version; fix dataclasses dependency for py 3.6 #14654
Conversation
ericl
changed the title
ericl
changed the title
| @@ -131,6 +131,7 @@ | |||
| "click >= 7.0", | |||
| "colorama", | |||
| "colorful", | |||
| "dataclasses; python_version < '3.7'", | |||
There was a problem hiding this comment.
@richardliaw did we move this accidentally recently? Python 3.6 used to work (and we have dependend on dataclasses in ray client since last year).
There was a problem hiding this comment.
I don't recall; though I think we didn't have the python version setup correctly before. dataclasses will break on 3.7.
|
@ericl this won't break every time we add a new |
|
I believe this is only since it was adding a new kwarg. I think we should be able to avoid this kind of breakage in the future, but it might require some refactoring of the Ray client protocol (cc @AmeerHajAli ) |
|
@ericl @AmeerHajAli actually we could make the client API very defensive and just transparently pass through all args and kwargs where possible, then have the failure happen on the remote side. That might be the best way to avoid these issues coming up repeatedly. |
|
It's a good question, I think we need to decide whether to support x-version calls for nightly builds and so on. For properly released Ray versions, we require exact version match. |
The addition of the .options(runtime_env) field breaks Ray client protocol compatibility. In addition, the dataclasses module was incorrectly moved to extras; it's needed for Ray client.