Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes][dashboard][minor] Fix uptime #14655

Merged
merged 20 commits into from
Mar 13, 2021

Conversation

DmitriGekhtman
Copy link
Contributor

@DmitriGekhtman DmitriGekhtman commented Mar 12, 2021

Why are these changes needed?

Quick one --
When in K8s, use container start time, not host boot time.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Tested experimentally.

@DmitriGekhtman
Copy link
Contributor Author

good to merge

@edoakes edoakes merged commit 6babd19 into ray-project:master Mar 13, 2021
@DmitriGekhtman DmitriGekhtman deleted the k8s-dashboard-uptime branch March 18, 2021 23:23
@AmeerHajAli AmeerHajAli added this to the Serverless Autoscaling milestone Apr 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants