Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autoscaler Docs] Use worker_run_options #14721

Merged
merged 2 commits into from
Mar 17, 2021
Merged

[Autoscaler Docs] Use worker_run_options #14721

merged 2 commits into from
Mar 17, 2021

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Mar 16, 2021

Why are these changes needed?

The field is worker_run_options, not run_options for the multi-node-type-autoscaler

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt ijrsvt requested a review from jvrdnd March 16, 2021 22:37
AmeerHajAli
AmeerHajAli requested changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@AmeerHajAli AmeerHajAli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. one minor change.

@ijrsvt @AmeerHajAli
Update doc/source/cluster/config.rst
4f298e5 
Co-authored-by: Ameer Haj Ali <ameerh@berkeley.edu>
@ijrsvt ijrsvt requested a review from AmeerHajAli March 16, 2021 23:00
@ijrsvt ijrsvt merged commit 8a936ad into ray-project:master Mar 17, 2021
@ijrsvt ijrsvt deleted the fix-worker-run-options-docs branch March 17, 2021 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmeerHajAli AmeerHajAli AmeerHajAli approved these changes

@jvrdnd jvrdnd Awaiting requested review from jvrdnd

Assignees

@AmeerHajAli AmeerHajAli

@jvrdnd jvrdnd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijrsvt @AmeerHajAli @jvrdnd