[serve] Add tests for backend_state versioning #14748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoakes
force-pushed
the
versioning-unit-tests
branch
from
ab10e3f
to
bfaa76e
Compare
edoakes
force-pushed
the
versioning-unit-tests
branch
from
bfaa76e
to
ed7fa89
Compare
edoakes
changed the title
6 tasks
architkulkarni
approved these changes
Mar 18, 2021
ijrsvt
reviewed
Mar 18, 2021
| assert mock_replicas[0].started | ||
| assert len(replicas(backend_state)) == 1 | ||
| assert len(replicas(backend_state, states=[ReplicaState.STARTING])) == 1 | ||
| assert replicas(backend_state)[0]._actor.started |
There was a problem hiding this comment.
Do we want to just keep a reference for all the tests?
starting_replica = replicas(backend_state)[0]
starting_replica._actor.started
...
starting_replica._actor.set_ready()
There was a problem hiding this comment.
yeah that's probably cleaner. the tests already passed here though so I'm going to merge to unblock my other PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
scripts/format.shto lint the changes in this PR.