[Tune] PTL Fractional GPUs #14781

amogkam · 2021-03-18T19:06:22Z

Closes #14624

Why are these changes needed?

I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

doc/source/tune/_tutorials/tune-pytorch-lightning.rst

python/ray/tune/examples/mnist_pytorch_lightning.py

richardliaw

lgtm ping when tests pass

Co-authored-by: Richard Liaw <rliaw@berkeley.edu>

amogkam · 2021-03-19T00:00:25Z

@richardliaw can you merge this please

richardliaw · 2021-03-19T00:09:15Z

nice! thanks for the ping and the fast turnaround here.

On Thu, Mar 18, 2021 at 5:00 PM Amog Kamsetty ***@***.***> wrote: @richardliaw <https://github.com/richardliaw> can you merge this please — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14781 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCRZZOVAR3XYF3463RK26TTEKH2RANCNFSM4ZNG2YVA> .

update doc

fc2c832

amogkam assigned richardliaw and krfricke Mar 18, 2021

amogkam requested review from krfricke and richardliaw March 18, 2021 19:07

richardliaw reviewed Mar 18, 2021

View reviewed changes

doc/source/tune/_tutorials/tune-pytorch-lightning.rst Outdated Show resolved Hide resolved

richardliaw reviewed Mar 18, 2021

View reviewed changes

python/ray/tune/examples/mnist_pytorch_lightning.py Outdated Show resolved Hide resolved

richardliaw approved these changes Mar 18, 2021

View reviewed changes

amogkam and others added 2 commits March 18, 2021 12:20

updates

45f2cdd

Update doc/source/tune/_tutorials/tune-pytorch-lightning.rst

312b024

Co-authored-by: Richard Liaw <rliaw@berkeley.edu>

richardliaw merged commit 7ee2e41 into ray-project:master Mar 19, 2021