Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Client] Test Serialization in a platform independent way. #14786

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Mar 18, 2021

Why are these changes needed?

  • The existing test caused:
  • FileNotFound on Windows (because /dev doesn't exist)
  • No Error on BuildKite (I assume because the environment allows writing to /dev?)

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt ijrsvt added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 18, 2021
@ijrsvt ijrsvt merged commit 00aceaa into ray-project:master Mar 19, 2021
@ijrsvt ijrsvt deleted the fix-ray-client-test branch March 19, 2021 01:24
@ijrsvt ijrsvt removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants