Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autoscaler][Azure] check if 'update' is available in #14787

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Mar 18, 2021

Why are these changes needed?

  • Newer versions of the Azure client do not seem to have VirtualMachineOperations::update, and instead have VirtualMachineOperations::begin_update.

Related issue number

Closes #14778

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@ijrsvt
Copy link
Contributor Author

ijrsvt commented Mar 18, 2021

@gramhagen Where can I find the lifecycle of update vs begin_update? I tried looking at some online docs and even looking at pervious versions, I saw now reference to update. That being said, I looked at the local python source code for the package, and saw update.

@gramhagen
Copy link
Contributor

gramhagen commented Mar 19, 2021

I believe the change happens >= 17

Check release notes for 17.0.0b1 https://pypi.org/project/azure-mgmt-compute/

Copy link
Contributor

@DmitriGekhtman DmitriGekhtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!

@ijrsvt ijrsvt changed the title [Autoscaler] check if 'update' is available [Autoscaler][Azure] check if 'update' is available in Mar 19, 2021
@ijrsvt ijrsvt merged commit 8574088 into ray-project:master Mar 19, 2021
@ijrsvt ijrsvt deleted the begin-update branch March 19, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: 'VirtualMachinesOperations' object has no attribute 'update'
3 participants