Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Deflake and re-enable client serve test #14813

Merged
merged 2 commits into from
Mar 20, 2021

Conversation

architkulkarni
Copy link
Contributor

Why are these changes needed?

Reverts #14733.

Ideally we would run this test, say, 10 times in a loop in the test to really ensure it's no longer flaky, but disconnecting and reconnecting the Ray Client still doesn't work with Serve (even with a non-detached Serve instance) so this isn't possible at the moment.

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@edoakes
Copy link
Contributor

edoakes commented Mar 20, 2021

Looks good. 2/2 passed on the PR build and it was deflaked upstream, so we should be ok here.

@edoakes edoakes merged commit 41e82db into ray-project:master Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants