Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Remove all non-trajectory view API code. #14860

Merged
merged 14 commits into from
Mar 23, 2021
Merged

[RLlib] Remove all non-trajectory view API code. #14860

merged 14 commits into from
Mar 23, 2021

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Mar 23, 2021 •
edited

Remove all non-trajectory view API code.

  • This PR removes the _use_trajectory_view_api config flag and all code related to pre-traj. view API logic.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Mar 23, 2021
@ericl
Copy link
Contributor

ericl commented Mar 23, 2021

Nice!

@ericl ericl merged commit 04bc0a9 into ray-project:master Mar 23, 2021
@sven1977 sven1977 deleted the remove_all_non_traj_view_api_code branch April 11, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericl ericl ericl approved these changes

@michaelzhiluo michaelzhiluo Awaiting requested review from michaelzhiluo

Assignees

@ericl ericl

@michaelzhiluo michaelzhiluo

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sven1977 @ericl @michaelzhiluo