Add tracing to Ray #14872
Merged
Add tracing to Ray #14872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
March 18, 2021 16:09
|
can you move all functions in the core files, and the dict_propogator, to a new file called tracing.py? |
simon-mo
reviewed
Mar 23, 2021
python/ray/dict_propagator.py
Outdated
| @@ -0,0 +1,15 @@ | |||
| from typing import Any, cast, Dict | |||
|
|
|||
python/ray/remote_function.py
Outdated
| self._function_name = ( | ||
| self._function.__module__ + "." + self._function.__name__) | ||
| function.__module__ + "." + function.__name__) | ||
| print(f"function name is {self._function_name}") |
python/ray/remote_function.py
Outdated
| @@ -105,6 +110,33 @@ def _remote_proxy(*args, **kwargs): | |||
|
|
|||
| self.remote = _remote_proxy | |||
|
|
|||
| @staticmethod | |||
| def _tracing_wrap_function(function): | |||
There was a problem hiding this comment.
move this to a pure function in tracing.py
There was a problem hiding this comment.
naming: inject_tracing_into_function(function)
python/ray/util/tracing.py
Outdated
|
|
||
|
|
||
| @contextmanager | ||
| def use_context(parent_context: Context, ) -> Generator[None, None, None]: |
There was a problem hiding this comment.
Suggested change
| def use_context(parent_context: Context, ) -> Generator[None, None, None]: | |
| def use_context(parent_context: Context) -> Generator[None, None, None]: |
python/ray/actor.py
Outdated
| @@ -131,6 +131,7 @@ def remote(self, *args, **kwargs): | |||
|
|
|||
| return FuncWrapper() | |||
|
|
|||
| @actor_method_tracing_local | |||
There was a problem hiding this comment.
naming: tracing_actor_invocation
python/ray/remote_function.py
Outdated
| @@ -169,6 +201,7 @@ def remote(self, *args, **kwargs): | |||
|
|
|||
| return FuncWrapper() | |||
|
|
|||
| @_propagate_trace | |||
simon-mo
reviewed
Mar 23, 2021
python/ray/util/tracing.py
Outdated
| from contextlib import contextmanager | ||
| import inspect | ||
| import os | ||
| import wrapt |
There was a problem hiding this comment.
let's try to remove wrapt as a dependency
amogkam
reviewed
Apr 28, 2021
| # Skip tracing for staticmethod or classmethod, because these method | ||
| # might not be called directly by remote calls. Additionally, they are | ||
| # tricky to get wrapped and unwrapped. | ||
| if is_static_method(_cls, name) or is_class_method(method): |
There was a problem hiding this comment.
Suggested change
| if is_static_method(_cls, name) or is_class_method(method): | |
| if is_static_method(_cls, name) or is_class_method(method) or not is_tracing_enabled(): |
and remove it from span_wrapper and async_span_wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds a prototype for OpenTelemetry tracing in Python level for Ray tasks and actors.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.