[serve] Support setting deployment options via kwargs #14935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
architkulkarni
approved these changes
Mar 28, 2021
python/ray/serve/api.py
Outdated
| ray_actor_options: Optional[Dict] = None, | ||
| config: Optional[BackendConfig] = None) -> "Deployment": | ||
| def options( | ||
| self, |
There was a problem hiding this comment.
Hadn't seen @classmethod before so I looked it up--it looks like it's idiomatic to for the first argument to be cls instead of self and to use cls.<...> instead of Deployment.<...> in the body of the method. I'm not sure if there's any concrete benefit to doing so though, unless we plan to subclass Deployment or change its name in the future.
There was a problem hiding this comment.
Ah yeah really good point, that would be much cleaner (it's weird to reference the class from within its own definition...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See updated tests for details.
Less verbose UX, more closely matches Ray API.
Also clarifies the
init_argsbehavior.Related issue number
Checks
scripts/format.shto lint the changes in this PR.