[core] Fix placement group GPU assignment bug #15049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
rkooo567
approved these changes
Mar 31, 2021
| ResourceInstanceCapacities *node_instances; | ||
| local_resources_.predefined_resources.resize(PredefinedResources_MAX); | ||
| if (kCPU_ResourceLabel == resource_name) { | ||
| node_instances = &local_resources_.predefined_resources[CPU]; |
There was a problem hiding this comment.
Why do you use &local_resources_. here? (Why do you use & in the beginning of this attribute?)
There was a problem hiding this comment.
To get a pointer. In an ideal world, c++ would let us do ResourceInstanceCapacities &node_instances then initialize it in the if statements, but this is the next best thing.
|
ASAN test failures (use after free) |
ericl
added
the
@author-action-required
added 2 commits
March 31, 2021 21:53
|
@wuisawesome can you add this to the release blocker spreadsheet please (along with ETA and any tests that need to be re-run). |
|
Small+large test failure is a CI bug. Looks fine in buildkite. Merging now. cc @amogkam |
This was referenced Apr 2, 2021
amogkam
pushed a commit
that referenced
this pull request
Apr 2, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When the new scheduler was implemented, we introduced a bug by assuming that all dynamic resources (including placement group resources) were non-unit resources. This assumption was fine for everything except GPUs. This PR fixes that by allowing dynamic, unit-resources.
A lot of this came from @clay4444 (especially the test cases!) in #14891
Related issue number
#14759
Checks
scripts/format.shto lint the changes in this PR.